Skip to content

Conversation

@divakaivan
Copy link
Contributor

Reference Issues/PRs

Fixes #502

What does this implement/fix? Explain your changes.

the issue stems from the change here - prior to sklearn 1.8 the collinearity case in QDA was a warning, now (in 1.8) it's an error. The warnings were not seen as they are supressed by the skops test setup.

Additions:

  • regularization to the QDA in tests to avoid the collinearity error
  • adding a new ci-sklearn18 to the gha
  • pyproject.toml update for the new version

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks

divakaivan and others added 2 commits January 5, 2026 13:31
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@adrinjalali
Copy link
Member

Catboost seems failing, they're infamously slow to release for new dependencies, you can ignore them for now for this CI with a todo ideally pointing to an existing issue (or one you'd create) on the catboost repo.

@divakaivan
Copy link
Contributor Author

divakaivan commented Jan 5, 2026

  • The docs build seems to be failing because of the fetch_california_housing 403 error - https://app.readthedocs.org/api/v2/build/30885603.txt - we can use this temp solution if needed
  • I commented out catboost in the 1.8 deps and added a comment to see things pass but not sure if you want it to remain like this?

@adrinjalali
Copy link
Member

The fetch california housing issue seems to be what we have in scikit-learn too.

@adrinjalali adrinjalali merged commit 9e225a1 into skops-dev:main Jan 5, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix sklearn=1.8 issues and release if required.

2 participants