-
Notifications
You must be signed in to change notification settings - Fork 62
MNT Fix CI issue from new scikit-learn==1.8.0 #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adrinjalali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM. Thanks
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
|
Catboost seems failing, they're infamously slow to release for new dependencies, you can ignore them for now for this CI with a todo ideally pointing to an existing issue (or one you'd create) on the catboost repo. |
|
|
The fetch california housing issue seems to be what we have in scikit-learn too. |
Reference Issues/PRs
Fixes #502
What does this implement/fix? Explain your changes.
the issue stems from the change here - prior to sklearn 1.8 the collinearity case in QDA was a warning, now (in 1.8) it's an error. The warnings were not seen as they are supressed by the skops test setup.
Additions: